Some mvt tests. #5149
Merged
Some mvt tests. #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhousel
reviewed
Jul 16, 2018
test/spec/svg/mvt.js
Outdated
|
|
||
| describe('#url', function() { | ||
| it('handles pbf url', function () { | ||
| var url = 'https://api.mapbox.com/v4/mapbox.mapbox-streets-v6/9/150/194.vector.pbf?access_token=' |
There was a problem hiding this comment.
We should avoid linking to a mapbox streets pbf here.
Can you try to use sinon to fake a response?
Here is an example in the OpenStreetCam test:
https://github.com/openstreetmap/iD/blob/master/test/spec/services/openstreetcam.js#L54-L105
I think it would be ok to store .pbf test fixture in the test/data folder, and use fs.readFile to load the data .
|
Cool, thanks for fixing these to avoid the network access! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bhousel!!
Here are some tests for #5072. Please check.